Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Quality of life Improvement: if disk requested is smaller than needed, will tell you and potentially adjust#330

Merged
jhaynie merged 2 commits intomainfrom
disk-adjust
May 22, 2025
Merged

Quality of life Improvement: if disk requested is smaller than needed, will tell you and potentially adjust#330
jhaynie merged 2 commits intomainfrom
disk-adjust

Conversation

@jhaynie
Copy link
Copy Markdown
Member

@jhaynie jhaynie commented May 22, 2025 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • New Features
    • Added disk size validation during bundling for both JavaScript and Python projects, prompting users to update deployment disk requests if needed.
  • Refactor
    • Bundling is now always performed during preflight checks, independent of prior configuration flags.

@jhaynie
Quality of life Improvement: if disk requested is smaller than needed…
f72b53c 
… in python, will tell you and potentially adjust
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2025 •
edited
Loading

Walkthrough

The changes introduce disk size validation during bundling for both JavaScript and Python projects by calculating directory sizes and comparing them to deployment disk requests. The BundleContext struct is extended to include a project reference. Bundling is now always performed during preflight checks, removing the previous conditional flag.

Changes

File(s) Change Summary
cmd/bundle.go Passes the Project field from projectContext into bundler.BundleContext for the bundling process.
internal/bundler/bundler.go Adds disk size validation for output directories, extends BundleContext with a Project pointer, and adds directory size calculation and user prompt logic.
internal/deployer/deployer.go Always performs bundling in PreflightCheck, removes conditional on Bundler.Enabled, and passes the Project field to the bundler.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Deployer
    participant Bundler
    participant Project

    User->>Deployer: Initiate PreflightCheck
    Deployer->>Bundler: Call Bundle(BundleContext{Project: Project})
    Bundler->>Project: Access deployment disk request
    Bundler->>Bundler: Calculate output directory size (.venv or JS output)
    alt Directory size > disk request
        Bundler->>User: Warn and prompt to adjust disk size (if TTY)
        alt User confirms
            Bundler->>Project: Update disk request and save
        else User declines or not TTY
            Bundler->>Deployer: Return error
        end
    end
    Bundler->>Deployer: Return result
    Deployer->>User: Report outcome
Loading

Poem

A bunny checks the disk with care,
Making sure there's space to spare.
If your venv grows too wide,
It gently nudges, "Please decide!"
Now bundling hops with context true,
Project in paw, it guides you through.
🐇💾✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f72b53c and 01f7b10.

📒 Files selected for processing (1)
  • internal/bundler/bundler.go (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • internal/bundler/bundler.go
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jhaynie jhaynie changed the title Quality of life Improvement: if disk requested is smaller than needed in python, will tell you and potentially adjust Quality of life Improvement: if disk requested is smaller than needed, will tell you and potentially adjust May 22, 2025
@jhaynie jhaynie requested a review from pec1985 May 22, 2025 16:20
@jhaynie jhaynie merged commit 42f4b0b into main May 22, 2025
14 checks passed
@jhaynie jhaynie deleted the disk-adjust branch May 22, 2025 18:22
This was referenced May 22, 2025
Merged
Merged
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pec1985 pec1985 Awaiting requested review from pec1985

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jhaynie